Add tests for bounded_int_mul libfunc
#1470
Draft
+334
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1470 +/- ##
==========================================
+ Coverage 81.69% 81.75% +0.06%
==========================================
Files 105 105
Lines 26047 26174 +127
==========================================
+ Hits 21279 21399 +120
- Misses 4768 4775 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.022 ± 0.087 | 10.924 | 11.192 | 4.47 ± 0.04 |
cairo-native (embedded AOT) |
2.468 ± 0.015 | 2.445 | 2.493 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.541 ± 0.017 | 2.522 | 2.574 | 1.03 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
515.7 ± 5.8 | 509.0 | 526.7 | 1.00 |
cairo-native (embedded AOT) |
2157.1 ± 10.5 | 2140.4 | 2176.0 | 4.18 ± 0.05 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2266.0 ± 15.5 | 2249.3 | 2295.5 | 4.39 ± 0.06 |
Benchmark for program factorial_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.788 ± 0.033 | 4.764 | 4.876 | 1.84 ± 0.01 |
cairo-native (embedded AOT) |
2.599 ± 0.011 | 2.579 | 2.613 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.649 ± 0.028 | 2.612 | 2.714 | 1.02 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
4.745 ± 0.034 | 4.702 | 4.831 | 2.23 ± 0.03 |
cairo-native (embedded AOT) |
2.132 ± 0.025 | 2.097 | 2.179 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2.217 ± 0.071 | 2.161 | 2.348 | 1.04 ± 0.04 |
Benchmark for program heavy_circuit
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
9.562 ± 0.067 | 9.447 | 9.674 | 1.00 |
cairo-native (embedded AOT) |
14.776 ± 0.096 | 14.695 | 15.018 | 1.55 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
15.099 ± 0.048 | 15.021 | 15.194 | 1.58 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
551.2 ± 7.8 | 542.2 | 565.8 | 1.00 |
cairo-native (embedded AOT) |
2255.9 ± 32.2 | 2206.2 | 2300.8 | 4.09 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2397.5 ± 53.1 | 2345.9 | 2489.9 | 4.35 ± 0.11 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
371.8 ± 4.8 | 366.9 | 382.7 | 1.00 |
cairo-native (embedded AOT) |
2291.0 ± 14.9 | 2276.9 | 2318.9 | 6.16 ± 0.09 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
2462.0 ± 8.8 | 2448.9 | 2473.8 | 6.62 ± 0.09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
bounded_int_mullibfuncRefactor of the algorithm to multiply
BoundedIntand addition of tests for different cases.We have C = A * B, where all of them are BoundedInt. We represent the a BoundedInt as:
So we want to get
Cdand we have:Co + Cd = ( Ao + Ad ) * ( Bo + Bd )->Cd = (Ad * Bd) + (Ad * Bo) + (Bd * Ao) + (Ao * Bo - Co)Closes #1450
Introduces Breaking Changes?
No.
Checklist